hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4128) AM Recovery expects all attempts of a completed task to also be completed.
Date Thu, 12 Apr 2012 19:47:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252773#comment-13252773
] 

Bikas Saha commented on MAPREDUCE-4128:
---------------------------------------

yeah. I asked the same question in my previous reviews but there was no clear clean method
to solve this. :(
I guess we might have to add a global suppress for this specific warning. Having tons of @suppress
on all these functions would be messy.

Do you have any clues on the Avro thing? My web search did not return anything useful. I moved
the new successfulTaskAttempt field to the end. That led to NPE later on because Avro set
null values into my TaskFinishedEvent.successfulAttemptId. So I had to check for null in TaskFinishedEvent.
I dont like it this way. 

Now the test passes. Is there a better way to do this?

                
> AM Recovery expects all attempts of a completed task to also be completed.
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4128
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4128
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 3.0.0
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4128-1.patch, MAPREDUCE-4128.patch
>
>
> The AM seems to assume that all attempts of a completed task (from a previous AM incarnation)
would also be completed. There is at least one case in which this does not hold. Case being
cancellation of a completed task resulting in a new running attempt.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message