hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4161) create sockets consistently
Date Wed, 18 Apr 2012 14:58:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256622#comment-13256622
] 

Robert Joseph Evans commented on MAPREDUCE-4161:
------------------------------------------------

Not done with the patch yet.  It looks good, but I have one minor comment about some of the
changes.  In a few places you replaced the creation of a YarnConfiguration object with just
a configuration object.  Yes most of the time this should really be a noop, but YarnConfiguration
does some static initialization, that I have seen issues in the past where if that was not
done in the correct order bad things happened.  I am just being paranoid here.
                
> create sockets consistently
> ---------------------------
>
>                 Key: MAPREDUCE-4161
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4161
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: client, mrv2
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: MAPREDUCE-4161-1.patch, MAPREDUCE-4161.patch
>
>
> Use getSocketAddr from HADOOP-8286 to ensure sockets are created consistently and compatible
for host-based service generation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message