hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3047) FileOutputCommitter throws wrong type of exception when calling abortTask() to handle a directory without permission
Date Tue, 10 Apr 2012 17:47:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250867#comment-13250867
] 

Hadoop QA commented on MAPREDUCE-3047:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522132/MAPREDUCE-3047-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 508 javac compiler warnings (more than the trunk's
current 507 warnings).

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
                  org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
                  org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
                  org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2186//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2186//console

This message is automatically generated.
                
> FileOutputCommitter throws wrong type of exception when calling abortTask() to handle
a directory without permission
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3047
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3047
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.24.0
>            Reporter: JiangKai
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-3047-1.patch, MAPREDUCE-3047.patch
>
>
> When FileOutputCommitter calls abortTask() to create a temp directory, if the user has
no permission to access the directory, or a file with the same name has existed, of course
it will fail, however the system will output the error information into the log file instead
of throwing an exception.As a result, when the temp directory is needed later, since the temp
directory hasn't been created yet, system will throw an exception to tell user that the temp
directory doesn't exist.In my opinion, the exception is not exact and the error infomation
will confuse users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message