hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4101) nodemanager depends on /bin/bash
Date Wed, 04 Apr 2012 15:01:25 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246326#comment-13246326
] 

Hadoop QA commented on MAPREDUCE-4101:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521313/bash-replace-by-sh.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor
                  org.apache.hadoop.yarn.server.nodemanager.containermanager.TestContainerManager
                  org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2146//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2146//console

This message is automatically generated.
                
> nodemanager depends on /bin/bash
> --------------------------------
>
>                 Key: MAPREDUCE-4101
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4101
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.1, trunk
>         Environment: FreeBSD 8.2 / 64 bit
>            Reporter: Radim Kolar
>              Labels: patch
>         Attachments: bash-replace-by-sh.txt
>
>
> Currently nodemanager depends on bash shell. It should be well documented for system
not having bash installed by default such as FreeBSD. Because only basic functionality of
bash is used, probably changing bash to /bin/sh would work enough.
> i found 2 cases:
> 1. DefaultContainerExecutor.java creates file with /bin/bash hardcoded in writeLocalWrapperScript.
(this needs bash in /bin)
> 2. yarn-hduser-nodemanager-ponto.amerinoc.com.log:2012-04-03 19:50:10,798 INFO org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor:
launchContainer: [bash, -c, /tmp/nm-local-dir/usercache/hduser/appcache/application_1333474251533_0002/container_1333474251533_0002_01_000012/default_container_executor.sh]
> this created script is also launched by bash - bash anywhere in path works - in freebsd
it is /usr/local/bin/bash

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message