hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4138) Reduce memory usage of counters due to non-static nested classes
Date Thu, 19 Apr 2012 20:14:40 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257750#comment-13257750
] 

Robert Joseph Evans commented on MAPREDUCE-4138:
------------------------------------------------

The change looks good to me, but could you take a look at the javac warning
{noformat}
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Counters.java:[396,25]
[unchecked] unchecked call to FrameworkCounter(T,java.lang.String) as a member of the raw
type org.apache.hadoop.mapreduce.counters.FrameworkCounterGroup.FrameworkCounter
{noformat}

                
> Reduce memory usage of counters due to non-static nested classes
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4138
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4138
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-4138.patch
>
>
> FrameworkCounter is a non-static nested class of FrameworkCounterGroup which means it
retains a reference to the outer class, which isn't really needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message