hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4188) Clean up yarn-server-web-proxy
Date Sun, 22 Apr 2012 19:33:33 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259219#comment-13259219
] 

Harsh J commented on MAPREDUCE-4188:
------------------------------------

The only change here is:

{code}
--- hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
+++ hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java
@@ -144,7 +144,6 @@ public class WebAppProxyServlet extends HttpServlet {
     config.setLocalAddress(localAddress);
     HttpMethod method = new GetMethod(uri.getEscapedURI());
 
-    @SuppressWarnings("unchecked")
     Enumeration<String> names = req.getHeaderNames();
     while(names.hasMoreElements()) {
       String name = names.nextElement();
{code}

And with my local JDK 1.6 (and Eclipse 3.7.x), the warning ought to reduce. I'm not sure why
we need an unchecked suppressor there, as the signature for {{req.getHeaderNames()}} is typed
in itself:

{{Enumeration<String> javax.servlet.http.HttpServletRequest.getHeaderNames()}}
                
> Clean up yarn-server-web-proxy
> ------------------------------
>
>                 Key: MAPREDUCE-4188
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4188
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: trunk
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: 0016-YARN-Server-Web-Proxy-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-web-proxy module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message