Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Thu, 15 Mar 2012 21:16:38 +0000 (UTC)
From: "Steve Loughran (Commented) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <746728782.21166.1331846198997.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <793531586.19146.1331821778613.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-4014) Make yarn-common services
 robust
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230558#comment-13230558 ] 

Steve Loughran commented on MAPREDUCE-4014:
-------------------------------------------

I'm going to submit an initial patch soon, but want to flag up something first. Should CompositeService attempt to {{stop()}} all its child services when told to {{stop()}} itself - regardless of what state the it is in? This would be consistent with a philosophy of "support the stop operation regardless of your state".

Without that you can't reliably clean up during failed start operations -which the CompositeService itself tries to do by stopping all child services if any one of them fails to start - including the service that failed.
                
> Make yarn-common services robust
> --------------------------------
>
>                 Key: MAPREDUCE-4014
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4014
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>              Labels: yarn
>
> Review the yarn common services ({{CompositeService}}, {{AbstractLivelinessMonitor}} and make their service startup _and especially shutdown_ more robust against out-of-lifecycle invocation and partially complete initialization.
> Write tests for these where possible. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira