Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Tue, 20 Mar 2012 18:39:38 +0000 (UTC)
From: "Alejandro Abdelnur (Updated) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1339315921.37693.1332268778699.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (MAPREDUCE-1740) NPE in getMatchingLevelForNodes
 when node locations are variable depth
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated MAPREDUCE-1740:
------------------------------------------

      Resolution: Fixed
        Assignee: Ahmed Radwan
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Thanks Ahmed. Committed to trunk and branch-1
                
> NPE in getMatchingLevelForNodes when node locations are variable depth
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1740
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1740
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.3
>            Reporter: Todd Lipcon
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-1740.patch, MAPREDUCE-1740_branch-1.0.patch, MAPREDUCE-1740_trunk.patch, mapreduce-1740.txt
>
>
> In getMatchingLevelForNodes, we assume that both nodes have the same "depth" (ie number of path components). If the user provides a topology script that assigns one node a path like /foo/bar/baz and another node a path like /foo/blah, this function will throw an NPE.
> I'm not sure if there are other places where we assume that all node locations have a constant number of paths. If so we should check the output of the topology script aggressively to be sure this is the case. Otherwise I think we simply need to add && n2 != null to the while loop

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira