Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6E8391CB for ; Mon, 5 Mar 2012 02:46:51 +0000 (UTC) Received: (qmail 74185 invoked by uid 500); 5 Mar 2012 02:46:51 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 74058 invoked by uid 500); 5 Mar 2012 02:46:51 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 73643 invoked by uid 99); 5 Mar 2012 02:46:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 02:46:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 02:46:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9D95481BC for ; Mon, 5 Mar 2012 02:45:19 +0000 (UTC) Date: Mon, 5 Mar 2012 02:45:19 +0000 (UTC) From: "Arun C Murthy (Updated) (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1206113061.21220.1330915519647.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <693537663.7340.1315562469838.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (MAPREDUCE-2967) PB implementations of all records should have getters, setters and getProto() properly synchronized MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-2967: ------------------------------------- Fix Version/s: (was: 0.23.1) 0.24.0 > PB implementations of all records should have getters, setters and getProto() properly synchronized > --------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-2967 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2967 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Affects Versions: 0.23.0 > Reporter: Vinod Kumar Vavilapalli > Assignee: Vinod Kumar Vavilapalli > Fix For: 0.24.0 > > > In the past, I've been bitten by multiple, very hard-to-debug race conditions with YARN+MR which all boiled down to locking bugs in PB implementation of various records. > The main reason seems to be that while the _getProto()_ method in each record rebuilds the protocol object, if someone accesses a filed using a getter, it returns zero or a null object. Because of this, while _getProto()_ is in progress, _hashCode()_, _equals()_, _toString()_ etc are all affected, leading to hard-to-debug races. I corned this down after much logging in almost all the cases. > Over time, we've fixed this for most of the ID records. > This JIRA should fix it for *all* the records once and for all. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira