Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Wed, 21 Mar 2012 06:49:45 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1177585075.40675.1332312585297.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <319264692.36448.1332253780405.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-4040) History links should use
 hostname rather than IP address.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234172#comment-13234172 ] 

Hadoop QA commented on MAPREDUCE-4040:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12519175/MAPREDUCE-4040.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2077//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2077//console

This message is automatically generated.
                
> History links should use hostname rather than IP address.
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-4040
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4040
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver, mrv2
>    Affects Versions: 0.23.2
>            Reporter: Bhallamudi Venkata Siva Kamesh
>            Priority: Minor
>         Attachments: MAPREDUCE-4040.patch
>
>
> While navigating from web page (eg: */cluster/app/<app-id>* ) to HS, browser displays IP address rather than hostname.
> {code:title=JobHistoryUtils.java|borderStyle=solid}
>     if (address.getAddress().isAnyLocalAddress() || 
>         address.getAddress().isLoopbackAddress()) {
>       sb.append(InetAddress.getLocalHost().getHostAddress());
>     }	
> }
> {code} 
> I *think* it is better to use hostname rather than IP address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira