hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3970) Add ServiceOperations class to aid working with Services
Date Fri, 09 Mar 2012 18:18:58 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226281#comment-13226281
] 

Hadoop QA commented on MAPREDUCE-3970:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517747/MAPREDUCE-3970.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 8 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2026//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2026//console

This message is automatically generated.
                
> Add ServiceOperations class to aid working with Services
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-3970
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3970
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: MAPREDUCE-3970.patch
>
>
> Add Helper methods to move things through lifecycles. init->start is common, stop-if-service!=null
another. Some static methods can execute these, and even call stop() if init() raises an exception.
These could go into a class ServiceOps in the same package. These can be used by those services
that wrap other services, and help manage more robust shutdowns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message