hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4010) TestWritableJobConf fails on trunk
Date Thu, 15 Mar 2012 15:11:45 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230233#comment-13230233
] 

Robert Joseph Evans commented on MAPREDUCE-4010:
------------------------------------------------

I am a bit confused why changing the test is the correct solution to this problem.  This test
has not changed in [3 and a half years|http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestWritableJobConf.java?view=log].
 The test predates Oozie, so I am very nervous about trying to maintain backwards compatibility
by modifying a test in what appears to be a non-backwards compatible way.

The patch is doing more changes then are needed even if changing the test is what is wanted.
 The only assertion that is failing is the size assertion.  The maps produced are identical,
so it is perhaps Configuration.size that we want to look at.  We do not need to pull out deprecated
keys, because if HADOOP-8167 is working properly it should make sure that iterator returns
the same thing.
                
> TestWritableJobConf fails on trunk
> ----------------------------------
>
>                 Key: MAPREDUCE-4010
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4010
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Jason Lowe
>            Assignee: Alejandro Abdelnur
>            Priority: Critical
>             Fix For: 0.23.3
>
>         Attachments: MAPREDUCE-4010.patch
>
>
> TestWritableJobConf is currently failing two tests on trunk:
> * testEmptyConfiguration
> * testNonEmptyConfiguration
> Appears to have been caused by HADOOP-8167.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message