Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Sat, 18 Feb 2012 01:28:00 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <195016702.53045.1329528480235.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1938825342.52783.1329524879675.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-3879) yarn script has vestiges of
 jsvc that need to be cleaned up
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210730#comment-13210730 ] 

Hadoop QA commented on MAPREDUCE-3879:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515053/MAPREDUCE-3879.patch.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1891//console

This message is automatically generated.
                
> yarn script has vestiges of jsvc that need to be cleaned up
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-3879
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3879
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: MAPREDUCE-3879.patch.txt
>
>
> If nodemanager is started under root (I know, I know). The following is displayed:
> {noformat}
> /usr/lib/jvm/java-6-sun/bin/java -Dproc_nodemanager -Xmx1000m -jvm server -Dhadoop.log.dir=/var/log/yarn -Dyarn.log.dir=/var/log/yarn -Dhadoop.log.file=yarn-yarn-nodemanager-ahmed-laptop.log -Dyarn.log.file=yarn-yarn-nodemanager-ahmed-laptop.log -Dyarn.home.dir=/usr/lib/hadoop -Dhadoop.root.logger=INFO,DRFA -Dyarn.root.logger=INFO,DRFA -Djava.library.path=/usr/lib/hadoop/lib/native -classpath /etc/hadoop/conf:/etc/hadoop/conf:/etc/hadoop/conf:/usr/lib/hadoop/share/hadoop/common/*::/usr/lib/hadoop/*:/usr/lib/hadoop/lib/*:/usr/lib/hadoop/:/usr/lib/hadoop/share/hadoop/hdfs/*:/usr/lib/hadoop/share/hadoop/mapreduce/*:/share/hadoop/mapreduce/*:/usr/lib/hadoop/share/hadoop/mapreduce/*:/usr/lib/hadoop/share/hadoop/mapreduce/lib/*:/etc/hadoop/conf/nm-config/log4j.properties org.apache.hadoop.yarn.server.nodemanager.NodeManager
> Unrecognized option: -jvm
> Could not create the Java virtual machine.
> {noformat}
> The culprit is this bit of code that looks suspiciously like what used to be in bin/hdfs in support of jsvc launch:
> {noformat}
> elif [ "$COMMAND" = "nodemanager" ] ; then
>   CLASSPATH=${CLASSPATH}:$YARN_CONF_DIR/nm-config/log4j.properties
>   CLASS='org.apache.hadoop.yarn.server.nodemanager.NodeManager'
>   if [[ $EUID -eq 0 ]]; then
>     YARN_OPTS="$YARN_OPTS -jvm server $YARN_NODEMANAGER_OPTS"
>   else
>     YARN_OPTS="$YARN_OPTS -server $YARN_NODEMANAGER_OPTS"
>   fi
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira