Return-Path: 
 <mapreduce-issues-return-41357-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A9DF49F6D
	for <apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org>;
 Thu, 16 Feb 2012 23:27:20 +0000 (UTC)
Received: (qmail 25425 invoked by uid 500); 16 Feb 2012 23:27:20 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 25388 invoked by uid 500); 16 Feb 2012 23:27:20 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 25380 invoked by uid 99); 16 Feb 2012 23:27:20 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2012 23:27:20 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2012 23:27:18 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 279001BBD8B
	for <mapreduce-issues@hadoop.apache.org>;
 Thu, 16 Feb 2012 23:26:57 +0000 (UTC)
Date: Thu, 16 Feb 2012 23:26:57 +0000 (UTC)
From: "Patrick Hunt (Updated) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1538873573.48781.1329434817163.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1859781381.48735.1329434460997.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (MAPREDUCE-3872) event handling races in
 ContainerLauncherImpl and TestContainerLauncher
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/MAPREDUCE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated MAPREDUCE-3872:
------------------------------------

    Attachment: MAPREDUCE-3872.patch

This patch fixes three issues:

1) ContainerLauncherImpl had a race in updating "allNodes". This might result in the pool size being incorrectly calculated.

2) test had an issues where waitForEvent could run forever

3) there's a race btw eventHandlingThread in ContainerLauncherImpl and the test code. In some cases the event would be processed, and the pool size increased, before all events had been processed (and allNodes updated with all new hosts). I believe this is the result of the test failure I documented in the description.
                
> event handling races in ContainerLauncherImpl and TestContainerLauncher
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3872
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3872
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.1
>            Reporter: Patrick Hunt
>         Attachments: MAPREDUCE-3872.patch
>
>
> TestContainerLauncher is failing intermittently for me.
> {noformat}
> junit.framework.AssertionFailedError: Expected: <null> but was: Expected 22 but found 21
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.assertTrue(Assert.java:20)
> 	at junit.framework.Assert.assertNull(Assert.java:233)
> 	at junit.framework.Assert.assertNull(Assert.java:226)
> 	at org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncher.testPoolSize(TestContainerLauncher.java:117)
> {noformat}
> Patch momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira