hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3685) There are some bugs in implementation of MergeManager
Date Wed, 22 Feb 2012 22:11:48 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214040#comment-13214040
] 

Ravi Prakash commented on MAPREDUCE-3685:
-----------------------------------------

Hi Anty,

Thanks for your contribution. :) 

{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
This seems like a pretty important patch to warrant unit tests ;-) I know its cumbersome but
we all have to :(

Also, please try to get the +1 from Hadoop QA.

bq. -1 patch. The patch command could not apply the patch.
Did you use the diff command to generate the patch? Is the patch command able to apply your
.patch file?

In case you weren't aware, dev-support/test-patch.sh <YOUR_PATCH_FILE> will run what
HadoopQA runs, so you don't have to get so many -1s on the JIRA ;-)



                
> There are some bugs in implementation of MergeManager
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-3685
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3685
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.1
>            Reporter: anty.rao
>            Assignee: Zhihong Yu
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3685-branch-0.23.1.patch, MAPREDUCE-3685-branch-0.23.1.patch,
MAPREDUCE-3685.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message