hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2855) ResourceBundle lookup during counter name resolution takes a lot of time
Date Thu, 23 Feb 2012 04:39:48 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214296#comment-13214296
] 

Hadoop QA commented on MAPREDUCE-2855:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515689/MR2855.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1913//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1913//console

This message is automatically generated.
                
> ResourceBundle lookup during counter name resolution takes a lot of time
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2855
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2855
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>              Labels: mrv2
>         Attachments: MR2855.txt
>
>
> Loading a job status page in trunk takes a lot of time, and it seems like most of the
time is spent resolving counter names. Looking through the JDK source, ResourceBundle.getBundle(String)
ends up calling getClassContext() which is not very efficient. I think if we pass our own
classloader manually it will be faster. In Counters.incrAllCounters, we may also be able to
avoid setting the counter name if one is already set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message