hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2855) ResourceBundle lookup during counter name resolution takes a lot of time
Date Tue, 28 Feb 2012 01:23:49 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217793#comment-13217793
] 

Vinod Kumar Vavilapalli commented on MAPREDUCE-2855:
----------------------------------------------------

Nothing much to review here *smile*

Looks good, +1.

bq. On another note, do we really need to use ResourceBundles for the counter names, or is
this something we can do away with?
Great question. Not even sure if anybody uses this at all. I guess we should just file a ticket
and see if someone responds.

Pushing this in.
                
> ResourceBundle lookup during counter name resolution takes a lot of time
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2855
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2855
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Siddharth Seth
>              Labels: mrv2
>         Attachments: MR2855.txt
>
>
> Loading a job status page in trunk takes a lot of time, and it seems like most of the
time is spent resolving counter names. Looking through the JDK source, ResourceBundle.getBundle(String)
ends up calling getClassContext() which is not very efficient. I think if we pass our own
classloader manually it will be faster. In Counters.incrAllCounters, we may also be able to
avoid setting the counter name if one is already set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message