hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2944) Improve checking of input for Api displayTasks()
Date Mon, 09 Jan 2012 00:14:39 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182331#comment-13182331
] 

Eli Collins commented on MAPREDUCE-2944:
----------------------------------------

Harsh, Xie,

1. The error messages should generate the lists of valid states and types from their definitions
rather than hard-coding them into the error messages.

2. Aren't these types and states defined somewhere already?  Seems like they're a public API
and therefore shouldn't have to duplicate the definition of them in taskTypes and taskStates.

                
> Improve checking of input for Api displayTasks() 
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2944
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2944
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.24.0
>            Reporter: XieXianshan
>            Assignee: XieXianshan
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-2944.patch, MAPREDUCE-2944.patch, MAPREDUCE-2944_v0.2.patch,
MAPREDUCE-2944_v0.3.patch
>
>
> The JobClient.displayTasks() will do nothing and won't throw any exception either, 
> while user call it with invalid type/state of task.
> To be more friendly,it's better to remain user to check his parameters with an exception.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message