hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3377) Compatibility issue with 0.20.203.
Date Mon, 23 Jan 2012 23:15:40 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191599#comment-13191599
] 

Harsh J commented on MAPREDUCE-3377:
------------------------------------

Hello Jane,

The patches are fine. I only have a few small nits, some given state of trunk today:

* For trunk:
** Please move the test into hadoop-mapreduce-client-jobclient project. All tests have recently
been moved into that. Sorry for this inconvenience but it seems to have happened very recently,
to bring them into the maven fold.

* For both:
** Rename test into something more appropriate, perhaps: {{TestMRFileOutputFormat}} for new
API.
** We could do with a test for the stable API as well, though there isn't a problem, it will
help prevent regressions. You can add this test in {{TestFileOutputFormat}}, as that already
targets stable API.

Thanks for taking the time to report and contribute!
                
> Compatibility issue with 0.20.203.
> ----------------------------------
>
>                 Key: MAPREDUCE-3377
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3377
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.203.0, 1.0.0
>         Environment: 0.20.203.0 standalone JDK 1.6 Linux
>            Reporter: Jane Chen
>            Assignee: Jane Chen
>             Fix For: 1.1.0
>
>         Attachments: err-after, err-before, mapreduce-3377-branch-1.patch, mapreduce-3377.patch,
mapreduce-3377.patch, mapreduce-3377.patch, out-after, out-before
>
>
> I have an OutputFormat which implements Configurable.  I set new config entries to a
job configuration during checkOutputSpec() so that the tasks will get the config entries through
the job configuration.  This works fine in 0.20.2, but stopped working starting from 0.20.203.
 With 0.20.203, my OutputFormat still has the configuration set, but the copy a task gets
does not have the new entries that are set as part of checkOutputSpec().  
> I believe that the problem is with JobClient.  The job configuration needs to wait till
checkOutputSpec() is returned before being cloned and submitted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message