Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37D5C9A63 for ; Thu, 8 Dec 2011 05:08:04 +0000 (UTC) Received: (qmail 10835 invoked by uid 500); 8 Dec 2011 05:08:04 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 10678 invoked by uid 500); 8 Dec 2011 05:08:03 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 10668 invoked by uid 99); 8 Dec 2011 05:08:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2011 05:08:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2011 05:08:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 24FE3106509 for ; Thu, 8 Dec 2011 05:07:40 +0000 (UTC) Date: Thu, 8 Dec 2011 05:07:40 +0000 (UTC) From: "Ravi Gummadi (Updated) (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <365557129.52389.1323320860152.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <632679151.52379.1323320620354.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (MAPREDUCE-3519) Deadlock in LocalDirsHandlerService and ShuffleHandler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated MAPREDUCE-3519: ------------------------------------ Attachment: 3519.patch Attaching patch with the fix. With this patch, nobody else other than LocalDirsHandlerService can access the configuration-which-gets-updated-based-on-disks-health. Please review and provide your comments. > Deadlock in LocalDirsHandlerService and ShuffleHandler > ------------------------------------------------------ > > Key: MAPREDUCE-3519 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3519 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: nodemanager > Affects Versions: 0.23.1, 0.24.0 > Reporter: Ravi Gummadi > Assignee: Ravi Gummadi > Fix For: 0.23.1 > > Attachments: 3519.patch > > > MAPREDUCE-3121 cloned Configuration object in LocalDirsHandlerService.init() to avoid others to access that configuration object. But since it is set in the base class of LocalDirsHandlerService using super.init(conf), it is reflected and is accessible to some other services. This is causing a deadlock when accessing this configuration object from LocalDirsHandlerService and ShuffleHandler along with AllocatorPerContext object. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira