Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Mon, 5 Dec 2011 23:06:40 +0000 (UTC)
From: =?utf-8?Q?Bruno_Mah=C3=A9_=28Commented=29_=28JIRA=29?= <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1241566620.43085.1323126400106.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1996273632.7117.1320685253171.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-3366) Mapreduce component should use
 consistent directory structure layout as HDFS/common
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MAPREDUCE-3366?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13163142#comment-13163142 ]=20

Bruno Mah=C3=A9 commented on MAPREDUCE-3366:
---------------------------------------

Here are some issues with that patch:

* In hadoop-mapreduce-project/hadoop-yarn/bin/yarn-config.sh :
Instead of using the hardcoded value "$bin/../", it would be eaiser to reus=
e what has been done in MAPREDUCE-3373.
For instance:
+DEFAULT_LIBEXEC_DIR=3D"$bin"/../libexec
+HADOOP_LIBEXEC_DIR=3D${HADOOP_LIBEXEC_DIR:-$DEFAULT_LIBEXEC_DIR}
+if [ -e "${HADOOP_LIBEXEC_DIR}/hadoop-config.sh" ]; then
+  . "${HADOOP_LIBEXEC_DIR}/hadoop-config.sh"

* Wouldn't it be less confusing to display the message "hadoop-config.sh no=
t found" instead of "Hadoop common not found." if hadoop-config.sh is not f=
ound?


* Why changing these lines:
-YARN_CONF_DIR=3D"${YARN_CONF_DIR:-$YARN_HOME/conf}"
+YARN_CONF_DIR=3D"${HADOOP_CONF_DIR:-$YARN_HOME/conf}

I would like to be able to specify a different YARN_CONF_DIR than HADOOP_CO=
NF_DIR whole not being in YARN_HOME/conf. This change reduces the choices


               =20
> Mapreduce component should use consistent directory structure layout as H=
DFS/common
> -------------------------------------------------------------------------=
----------
>
>                 Key: MAPREDUCE-3366
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3366
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>         Environment: Java, Maven
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>         Attachments: MAPREDUCE-3366-1-trunk.patch, MAPREDUCE-3366.patch
>
>
> Directory structure for MRv2 layout looks like:
> {noformat}
> hadoop-mapreduce-0.23.0-SNAPSHOT/bin
>                                 /conf
>                                 /lib
>                                 /modules
> {noformat}
> The directory structure layout should be updated to reflect changes imple=
mented in HADOOP-6255.
> {noformat}
> hadoop-mapreduce-0.23.0-SNAPSHOT/bin
>                                 /etc/hadoop
>                                 /lib
>                                 /libexec
>                                 /sbin
>                                 /share/hadoop
>                                 /share/hadoop/lib
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira