hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun C Murthy (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3522) Capacity Scheduler ACLs not inherited by default
Date Thu, 29 Dec 2011 07:26:30 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177043#comment-13177043
] 

Arun C Murthy commented on MAPREDUCE-3522:
------------------------------------------

Jonathan, the patch looks good; and the docs!

Minor nit:
{code}
+    String defaultAcl = queue.contains(DOT) ? NONE_ACL : ALL_ACL;
{code}

could be more direct, like:

{code}
+    public static final String ROOT = "root"; // Move to CapacitySchedulerConfiguration from
CapacityScheduler
+    String defaultAcl = queue.equals(ROOT) ? NONE_ACL : ALL_ACL;
{code}
                
> Capacity Scheduler ACLs not inherited by default
> ------------------------------------------------
>
>                 Key: MAPREDUCE-3522
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3522
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: MAPREDUCE-3522.patch, MAPREDUCE-3522.patch, MAPREDUCE-3522.patch
>
>
> Hierarchical Queues do not inherit parent ACLs correctly by default. Instead, if no value
is specified for submit or administer acls, then all access is granted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message