hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Mahé (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3366) Mapreduce component should use consistent directory structure layout as HDFS/common
Date Mon, 05 Dec 2011 23:06:40 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163142#comment-13163142
] 

Bruno Mahé commented on MAPREDUCE-3366:
---------------------------------------

Here are some issues with that patch:

* In hadoop-mapreduce-project/hadoop-yarn/bin/yarn-config.sh :
Instead of using the hardcoded value "$bin/../", it would be eaiser to reuse what has been
done in MAPREDUCE-3373.
For instance:
+DEFAULT_LIBEXEC_DIR="$bin"/../libexec
+HADOOP_LIBEXEC_DIR=${HADOOP_LIBEXEC_DIR:-$DEFAULT_LIBEXEC_DIR}
+if [ -e "${HADOOP_LIBEXEC_DIR}/hadoop-config.sh" ]; then
+  . "${HADOOP_LIBEXEC_DIR}/hadoop-config.sh"

* Wouldn't it be less confusing to display the message "hadoop-config.sh not found" instead
of "Hadoop common not found." if hadoop-config.sh is not found?


* Why changing these lines:
-YARN_CONF_DIR="${YARN_CONF_DIR:-$YARN_HOME/conf}"
+YARN_CONF_DIR="${HADOOP_CONF_DIR:-$YARN_HOME/conf}

I would like to be able to specify a different YARN_CONF_DIR than HADOOP_CONF_DIR whole not
being in YARN_HOME/conf. This change reduces the choices


                
> Mapreduce component should use consistent directory structure layout as HDFS/common
> -----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3366
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3366
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>         Environment: Java, Maven
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>         Attachments: MAPREDUCE-3366-1-trunk.patch, MAPREDUCE-3366.patch
>
>
> Directory structure for MRv2 layout looks like:
> {noformat}
> hadoop-mapreduce-0.23.0-SNAPSHOT/bin
>                                 /conf
>                                 /lib
>                                 /modules
> {noformat}
> The directory structure layout should be updated to reflect changes implemented in HADOOP-6255.
> {noformat}
> hadoop-mapreduce-0.23.0-SNAPSHOT/bin
>                                 /etc/hadoop
>                                 /lib
>                                 /libexec
>                                 /sbin
>                                 /share/hadoop
>                                 /share/hadoop/lib
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message