hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3485) DISKS_FAILED -101 error code should be defined in same location as ABORTED_CONTAINER_EXIT_STATUS
Date Thu, 01 Dec 2011 10:51:40 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160804#comment-13160804
] 

Hadoop QA commented on MAPREDUCE-3485:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505751/3485.v1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1377//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1377//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-examples.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1377//console

This message is automatically generated.
                
> DISKS_FAILED -101 error code should be defined in same location as ABORTED_CONTAINER_EXIT_STATUS
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3485
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3485
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Hitesh Shah
>            Assignee: Ravi Gummadi
>             Fix For: 0.23.1
>
>         Attachments: 3485.patch, 3485.v1.patch
>
>
> With MAPREDUCE-3121, it is defined in ContainerExecutor as part of yarn-nodemanager which
would be a problem for client-side code if it needs to understand the exit code. 
> A short term fix would be to move it into YarnConfiguration where ABORTED_CONTAINER_EXIT_STATUS
is defined. A longer term fix would be to find a more formal and extensible approach for new
yarn framework error codes to be added and be easily accessible to client-side code or other
AMs. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message