Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Wed, 9 Nov 2011 12:54:51 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1947495915.14149.1320843291720.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <935304531.52916.1320269854001.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-3336)
 com.google.inject.internal.Preconditions not public api - shouldn't be
 using it
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147010#comment-13147010 ] 

Hudson commented on MAPREDUCE-3336:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #159 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/159/])
    MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the public Preconditions API. Contributed by Thomas Graves.
svn merge -c r1199714 --ignore-ancestry ../../trunk/

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199716
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java

                
> com.google.inject.internal.Preconditions not public api - shouldn't be using it
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3336
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Critical
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from in guice 2.0 it was an internal api and shouldn't have been used.   We should use com.google.common.base.Preconditions instead.
> This is currently being used in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira