hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it
Date Wed, 09 Nov 2011 13:27:52 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147034#comment-13147034
] 

Hudson commented on MAPREDUCE-3336:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #892 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/892/])
    MAPREDUCE-3336. Replaced guice internal.Preconditions api usage with the public Preconditions
API. Contributed by Thomas Graves.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199714
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java

                
> com.google.inject.internal.Preconditions not public api - shouldn't be using it
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3336
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Critical
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from in guice
2.0 it was an internal api and shouldn't have been used.   We should use com.google.common.base.Preconditions
instead.
> This is currently being used in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message