hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-3336) com.google.inject.internal.Preconditions not public api - shouldn't be using it
Date Wed, 09 Nov 2011 12:44:51 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinod Kumar Vavilapalli updated MAPREDUCE-3336:
-----------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.1
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I would have removed the usage of this API altogether, but that's me.

Just committed this to trunk and branch-0.23. Thanks Thomas!
                
> com.google.inject.internal.Preconditions not public api - shouldn't be using it
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3336
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3336
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Critical
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3336.patch
>
>
> com.google.inject.internal.Preconditions does not exist in guice 3.0 and from in guice
2.0 it was an internal api and shouldn't have been used.   We should use com.google.common.base.Preconditions
instead.
> This is currently being used in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message