Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Mon, 3 Oct 2011 17:35:34 +0000 (UTC)
From: "Robert Joseph Evans (Commented) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1158522800.3633.1317663334284.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <504458947.18897.1315859110086.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-2988) Reenable
 TestLinuxContainerExecutor reflecting the current NM code.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119424#comment-13119424 ] 

Robert Joseph Evans commented on MAPREDUCE-2988:
------------------------------------------------

The issue is not with passing in the correct information or setting up a dependency on the binary.  I can easily set up maven to pass in the container-executor.conf.dir and have the tests only run when the binary build is also enabled.  I had all of that setup before I went down the mock route.  I did that because I could not see a way to set up the taskcontroller.cfg reliably for the tests.  I don't see much use in having tests that will hardly ever be run because they need to be run in a complex 4 step semi-manual process requiring root privileges.  I can see the importance of having tests like those that are more integration tests.

Is there a reason that container-executor.conf.dir, HADOOP_HOME to the C code, must be set at compile time?  Why can't we pass it in on the command line.  I know that this is security related so if there are valid reasons I am happy to hear them, but I don't see any.  The executable will be set with the setuid bit so that it can become a different user, but the execution permissions for it are restricted to the mapred group, so only members of that group can run this code anyways.
                
> Reenable TestLinuxContainerExecutor reflecting the current NM code. 
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2988
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2988
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, security, test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Eric Payne
>            Assignee: Robert Joseph Evans
>            Priority: Critical
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MR-2988.txt, MR-2988.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> TestLinuxContainerExecutor is currently disabled completely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira