hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2913) TestMRJobs.testFailingMapper does not assert the correct thing.
Date Thu, 06 Oct 2011 13:28:30 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121937#comment-13121937
] 

Hudson commented on MAPREDUCE-2913:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #852 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/852/])
    MAPREDUCE-2913. Fixed TestMRJobs.testFailingMapper to assert the correct TaskCompletionEventStatus.
Contributed by Jonathan Eagles.

vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179319
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java

                
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2913
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Jonathan Eagles
>            Priority: Critical
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MAPREDUCE-2913.patch
>
>
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[0].getStatus().FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail.  If we remove the {code}.FAILED{code} the
asserts no longer pass. This could be because MRApp mocks out the task launcher and never
actually launches anything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message