hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call from org.apache.hadoop.record package in MR.
Date Fri, 28 Oct 2011 13:46:32 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138342#comment-13138342

Harsh J commented on MAPREDUCE-3302:

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

The patch provides mere inlining of code to remove a deprecated function call, since the deprecated
package is going away. {{WritableComparator#compareBytes}} is otherwise well tested already
by existing tests.

Hence, no test case is specifically required for this change.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>                 Key: MAPREDUCE-3302
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: client
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.24.0
>         Attachments: MAPREDUCE-3302.patch
> SecureShuffleUtils provides the following helper:
> {code}
>   /**
>    * verify that hash equals to HMacHash(msg)
>    * @param newHash
>    * @return true if is the same
>    */
>   private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
>     byte[] msg_hash = generateByteHash(msg, key);
>     return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) ==
>   }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}}
common package going away via HADOOP-7781, the internal (and also deprecated on the whole)
{{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
>   public static int compareBytes(byte[] b1, int s1, int l1,
>                                  byte[] b2, int s2, int l2) {
>     return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
>   }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call.
I'll put up a patch with this inline replacement shortly for review.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message