hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2913) TestMRJobs.testFailingMapper does not assert the correct thing.
Date Wed, 05 Oct 2011 16:39:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121117#comment-13121117
] 

Hadoop QA commented on MAPREDUCE-2913:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12497804/MAPREDUCE-2913.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/951//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/951//console

This message is automatically generated.
                
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2913
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Jonathan Eagles
>            Priority: Critical
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MAPREDUCE-2913.patch
>
>
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[0].getStatus().FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail.  If we remove the {code}.FAILED{code} the
asserts no longer pass. This could be because MRApp mocks out the task launcher and never
actually launches anything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message