Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Thu, 29 Sep 2011 06:30:46 +0000 (UTC)
From: "Vinod Kumar Vavilapalli (Updated) (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1696846613.6508.1317277846435.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <336890509.367.1317075072576.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (MAPREDUCE-3098) Report Application status as well
 as ApplicationMaster status in GetApplicationReportResponse
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3098:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Thanks Hitesh.

Looked at the patch, looks good, barring the mostly-minor comments below:
 - Not related to your patch, but can you please remove RESTARTING state from YarnApplicationState and from the proto definition? This isn't used anywhere.
 - RmAppImpl.createFinalApplicationStatus() incorrectly returns FinalApplicationStatus.KILLED for RMAppState.FINISHED. This should instead be FAILED.
 - We should rename _RMAppAttemptUnregistrationEvent.getApplicationFinishState()_ to _getFinalApplicationStatus()_.
 - AppsBlock.java: Please separate the columns for ApplicationState and FinalApplicationStatus like I mentioned above.
 - Also fix the app-page(RMController.app()) to have separate entries for the application-state and the final-status.
 - _NotRunningJob.getUnknownApplicationReport()_
    -- Can use Builderutils.createApplicationReport()
    -- Can remove the log message.
    -- Also for unknown app, the appstate and finalState are never used by NotRunningJob. So let's put a comment like that and may be initialize them to NEW and UNDEFINED respectively.

Meta comment: The patch is much larger than necessary because of the removal of extraneous spaces. I can pass for this patch, no need to undo it. But my general inclination is to avoid completely unrelated formatting changes to the patch in question.
                
> Report Application status as well as ApplicationMaster status in GetApplicationReportResponse 
> ----------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3098
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: MR-3098.1.patch, MR-3098.2.patch
>
>
> Currently, an application report received by the client from the RM/ASM for a given application returns the status of the application master. It does not return the status of the application i.e. whether that particular job succeeded or failed. 
> The AM status would be one of FINISHED (SUCCEEDED should be renamed to FINISHED as AM state does not indicate overall success/failure), FAILED or KILLED. 
> The final state sent by the AM to the RM in the FinishApplicationMasterRequest should be exposed to the client as ApplicationState. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira