Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Thu, 22 Sep 2011 22:57:26 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <1208897926.4093.1316732246779.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1713823593.46960.1313620707236.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MAPREDUCE-2850) TaskTracker disk failure
 handling (MR-2413) has no test coverage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112998#comment-13112998 ] 

Eli Collins commented on MAPREDUCE-2850:
----------------------------------------

Took a quick look:

In prepareDirToFail it says the file is set to perms "000" but File#createNewFile uses the default perms (eg 644 with umask 022), so it should still be accessible right?

If you want not always have waitForDiskHealthCheck wait for 10s at a time seems like you can lower the DISK_HEALTH_CHECK_INTERVAL to eg 1s.

Would also be good to test startup with a failed directory. Feel free to punt this to MAPREDUCE-2921.

Otherwise looks good.

> TaskTracker disk failure handling (MR-2413) has no test coverage
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-2850
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2850
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: tasktracker
>    Affects Versions: 0.20.204.0
>            Reporter: Eli Collins
>            Assignee: Ravi Gummadi
>             Fix For: 0.20.205.0
>
>         Attachments: MR2850.v0.patch
>
>
> MR-2413 doesn't have any test coverage that eg tests that the TT can survive disk failure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira