hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2985) findbugs error in ResourceLocalizationService.handle(LocalizationEvent)
Date Mon, 12 Sep 2011 21:49:08 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103094#comment-13103094
] 

Hadoop QA commented on MAPREDUCE-2985:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494125/MAPREDUCE-2985.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/710//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/710//console

This message is automatically generated.

> findbugs error in ResourceLocalizationService.handle(LocalizationEvent)
> -----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2985
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2985
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: MAPREDUCE-2985.patch
>
>
> hudson mapreduce is reporting a findbugs error:
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/707//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
> WMI 	Method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.handle(LocalizationEvent)
makes inefficient use of keySet iterator instead of entrySet iterator
> 	
> Bug type WMI_WRONG_MAP_ITERATOR (click for details)
> In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService
> In method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ResourceLocalizationService.handle(LocalizationEvent)
> At ResourceLocalizationService.java:[line 295]
> Another occurrence at ResourceLocalizationService.java:[line 318]

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message