hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2780) Standardize the value of token service
Date Tue, 09 Aug 2011 20:52:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081916#comment-13081916
] 

Daryn Sharp commented on MAPREDUCE-2780:
----------------------------------------

    [exec] +1 overall.
    [exec]
    [exec]     +1 @author.  The patch does not contain any @author tags.
    [exec]
    [exec]     +1 tests included.  The patch appears to include 15 new or modified tests.
    [exec]
    [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
    [exec]
    [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
    [exec]
    [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
    [exec]

> Standardize the value of token service
> --------------------------------------
>
>                 Key: MAPREDUCE-2780
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2780
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.20.205.0
>
>         Attachments: MAPREDUCE-2780-2.patch, MAPREDUCE-2780-3.patch, MAPREDUCE-2780-4.patch,
MAPREDUCE-2780.patch
>
>
> The token's service field must (currently) be set to "ip:port".  All the producers of
a token are independently building the service string.  This should be done via a common method
to reduce the chance of error, and to facilitate the field value being easily changed in the
(near) future.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message