hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Radwan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2788) LeafQueue.assignContainer() can cause a crash if request.getCapability().getMemory() == 0
Date Tue, 23 Aug 2011 18:30:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089647#comment-13089647
] 

Ahmed Radwan commented on MAPREDUCE-2788:
-----------------------------------------

Thanks Arun! The LeafQueue uses the CapacitySchedulerContext interface (CS is an implementation),
so other implementations can be added. We don't need to tie the LeafQueue to the CS implementation.
So I think the LeafQueue.assignContainer() should check/ensure that the request has no zero
memory request before dividing by zero. In my last patch I added normalizeRequest() to the
interface so any other implementations are enforced to implement this method (which takes
care of this zero memory case). What do you think?  

> LeafQueue.assignContainer() can cause a crash if request.getCapability().getMemory()
== 0
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2788
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2788
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-2788.patch, MAPREDUCE-2788_rev2.patch
>
>
> The assignContainer() method in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue
can cause the scheduler to crash if the ResourseRequest capability memory == 0 (divide by
zero).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message