Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D065C6B75 for ; Tue, 12 Jul 2011 21:29:28 +0000 (UTC) Received: (qmail 54386 invoked by uid 500); 12 Jul 2011 21:29:28 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 54018 invoked by uid 500); 12 Jul 2011 21:29:27 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 53771 invoked by uid 99); 12 Jul 2011 21:29:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2011 21:29:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2011 21:29:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 38E734CC6F for ; Tue, 12 Jul 2011 21:29:00 +0000 (UTC) Date: Tue, 12 Jul 2011 21:29:00 +0000 (UTC) From: "Ahmed Radwan (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1856797614.7589.1310506140230.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1586587604.10138.1310103916675.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (MAPREDUCE-2661) MR-279: Accessing MapTaskImpl from TaskImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Radwan updated MAPREDUCE-2661: ------------------------------------ Attachment: MAPREDUCE-2661_rev3.patch Thanks Devaraj for your review! > I feel it is not correct to give the getSplitsAsString() implementation details of MapTaskImpl.java and ReduceTaskImpl.java in TaskImpl.java. Yes, and this is why the patch pushes the implementation detail to subclasses. > TaskImpl.java can provide default implementation of getSplitsAsString() instead of making it as abstract and returning with empty string in ReduceTaskImpl.java. Agree, it will be similar that way. I have updated the patch accordingly. Thanks > MR-279: Accessing MapTaskImpl from TaskImpl > ------------------------------------------- > > Key: MAPREDUCE-2661 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv2 > Reporter: Ahmed Radwan > Assignee: Ahmed Radwan > Priority: Minor > Fix For: 0.23.0 > > Attachments: MAPREDUCE-2661.patch, MAPREDUCE-2661_rev2.patch, MAPREDUCE-2661_rev3.patch > > > We are directly accessing MapTaskImpl in TaskImpl.InitialScheduleTransition.transition(..). It'll be better to reorganize the code so each subclass can provide its own behavior instead of explicitly checking for the subclass type. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira