hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2630) MR-279: refreshQueues leads to NPEs when used w/FifoScheduler
Date Tue, 12 Jul 2011 16:14:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063973#comment-13063973
] 

Hadoop QA commented on MAPREDUCE-2630:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12485614/MAPREDUCE-2630-simple.patch
  against trunk revision 1145424.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/456//console

This message is automatically generated.

> MR-279: refreshQueues leads to NPEs when used w/FifoScheduler
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-2630
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2630
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>         Environment: All
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: MAPREDUCE-2630-simple.patch, MAPREDUCE-2630.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The RM's admin service exposes a method refreshQueues that is used to update the queue
configuration when used with the CapacityScheduler, but if it is used with the FifoScheduler,
it will set the containerTokenSecretManager/clusterTracker fields on the FifoScheduler to
null, which eventually leads to NPE. Since the FifoScheduler only has one queue that cannot
be refreshed, the correct behavior is for the refreshQueues call to be a no-op.
> I will attach a patch that fixes this by splitting the ResourceScheduler's reinitialize
method into separate initialize/updateQueues methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message