hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
Date Fri, 01 Jul 2011 17:14:28 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058657#comment-13058657
] 

Hadoop QA commented on MAPREDUCE-2631:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12484872/MAPREDUCE-2631.patch
  against trunk revision 1140942.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 3 release audit warnings (more than the
trunk's current 2 warnings).

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestMRCLI
                  org.apache.hadoop.fs.TestFileSystem

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/434//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/434//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/434//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/434//console

This message is automatically generated.

> Potential resource leaks in BinaryProtocol$TeeOutputStream.java and TaskLogServlet.java
> ---------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2631
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2631.patch
>
>
> {code:title=TaskLogServlet.java|borderStyle=solid}
> private void printTaskLog(HttpServletResponse response,
>                             OutputStream out, TaskAttemptID taskId, 
>                             long start, long end, boolean plainText, 
>                             TaskLog.LogName filter, boolean isCleanup) 
>   throws IOException {
>     if (!plainText) {
>       out.write(("<br><b><u>" + filter + " logs</u></b><br>\n"
+
>                  "<pre>\n").getBytes());
>     }
>     try {
>       InputStream taskLogReader = 
>         new TaskLog.Reader(taskId, filter, start, end, isCleanup);
>       byte[] b = new byte[65536];
>       int result;
>       while (true) {
>         result = taskLogReader.read(b);
>         if (result > 0) {
>           if (plainText) {
>             out.write(b, 0, result); 
>           } else {
>             HtmlQuoting.quoteHtmlChars(out, b, 0, result);
>           }
>         } else {
>           break;
>         }
>       }
>       taskLogReader.close();
> {code} 
> In the above code, if any exception thrown while reading (taskLogReader.read(b)), taskLogReader
will not be closed.
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
>       flush();
>       file.close();
>       out.close();
>     }
> {code} 
> In the above code, if the file.close() throws any exception out will not be closed.
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message