hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MAPREDUCE-2573) New findbugs warning after MAPREDUCE-2494
Date Tue, 07 Jun 2011 21:57:58 GMT
New findbugs warning after MAPREDUCE-2494
-----------------------------------------

                 Key: MAPREDUCE-2573
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
             Project: Hadoop Map/Reduce
          Issue Type: Bug
            Reporter: Todd Lipcon


MAPREDUCE-2494 introduced the following findbugs warning in trunk:
TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a
_static_ inner class?

This class is an inner class, but does not use its embedded reference to the object which
created it.  This reference makes the instances of the class larger, and may keep the reference
to the creator object alive longer than necessary.  If possible, the class should be made
static.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message