hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2573) New findbugs warning after MAPREDUCE-2494
Date Thu, 09 Jun 2011 23:07:58 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046908#comment-13046908
] 

Hudson commented on MAPREDUCE-2573:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #720 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/720/])
    MAPREDUCE-2573. Fix new findbugs warning introduced by MAPREDUCE-2494. Contributed by
Robert Joseph Evans.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134121
Files : 
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/filecache/TrackerDistributedCacheManager.java
* /hadoop/mapreduce/trunk/CHANGES.txt


> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
>                 Key: MAPREDUCE-2573
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Todd Lipcon
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0
>
>         Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir
be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which
created it.  This reference makes the instances of the class larger, and may keep the reference
to the creator object alive longer than necessary.  If possible, the class should be made
static.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message