Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E9AA4646 for ; Thu, 19 May 2011 15:47:30 +0000 (UTC) Received: (qmail 7502 invoked by uid 500); 19 May 2011 15:47:30 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 7474 invoked by uid 500); 19 May 2011 15:47:30 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 7466 invoked by uid 99); 19 May 2011 15:47:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 May 2011 15:47:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 May 2011 15:47:28 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A0DBED1CF9 for ; Thu, 19 May 2011 15:46:47 +0000 (UTC) Date: Thu, 19 May 2011 15:46:47 +0000 (UTC) From: "Hudson (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1886672995.26981.1305820007655.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <17542463.320631294860046055.JavaMail.jira@thor> Subject: [jira] [Commented] (MAPREDUCE-2258) IFile reader closes stream and compressor in wrong order MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036258#comment-13036258 ] Hudson commented on MAPREDUCE-2258: ----------------------------------- Integrated in Hadoop-Mapreduce-trunk #684 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/684/]) MAPREDUCE-2258. IFile reader closes stream and compressor in wrong order. Contributed by Todd Lipcon. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124383 Files : * /hadoop/mapreduce/trunk/CHANGES.txt * /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/IFile.java > IFile reader closes stream and compressor in wrong order > -------------------------------------------------------- > > Key: MAPREDUCE-2258 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2258 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: task > Affects Versions: 0.20.4, 0.22.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.23.0 > > Attachments: mapreduce-2258.txt > > > In IFile.Reader.close(), we return the decompressor to the pool and then call close() on the input stream. This is backwards and causes a rare race in the case of LzopCodec, since LzopInputStream makes a few calls on the decompressor object inside close(). If another thread pulls the decompressor out of the pool and starts to use it in the meantime, the first thread's close() will cause the second thread to potentially miss pieces of data. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira