hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2338) Deprecate field selection methods on JobConf
Date Wed, 18 May 2011 20:42:47 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035656#comment-13035656
] 

Hadoop QA commented on MAPREDUCE-2338:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12479068/MR-2338.2.patch
  against trunk revision 1104687.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//console

This message is automatically generated.

> Deprecate field selection methods on JobConf
> --------------------------------------------
>
>                 Key: MAPREDUCE-2338
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: James Warren
>              Labels: newbie
>         Attachments: MR-2338.1.patch, MR-2338.2.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear
as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator
and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and
deprecate the references in JobConf.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message