hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MAPREDUCE-2548) Log improvements in DBOutputFormat.java and CounterGroup.java
Date Tue, 31 May 2011 05:40:47 GMT
Log improvements in DBOutputFormat.java and CounterGroup.java
-------------------------------------------------------------

                 Key: MAPREDUCE-2548
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
            Reporter: Devaraj K
            Assignee: Devaraj K


1. Instead of the printing the stack trace on the console, It can be logged. 


{code:title=DBOutputFormat.java|borderStyle=solid}
    
public void write(K key, V value) throws IOException {
      try {
        key.write(statement);
        statement.addBatch();
      } catch (SQLException e) {
        e.printStackTrace();
      }
    }
{code}


2. Missing resource information can be logged. 

{code:title=CounterGroup .java|borderStyle=solid}

protected CounterGroup(String name) {
    this.name = name;
    try {
      bundle = getResourceBundle(name);
    }
    catch (MissingResourceException neverMind) {
    }
    displayName = localize("CounterGroupName", name);
  }


  private String localize(String key, String defaultValue) {
    String result = defaultValue;
    if (bundle != null) {
      try {
        result = bundle.getString(key);
      }
      catch (MissingResourceException mre) {
      }
    }
    return result;
  }
{code}
    




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message