hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2322) Throw better error message when malformed filenames in history dir
Date Thu, 19 May 2011 02:30:47 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035950#comment-13035950
] 

Todd Lipcon commented on MAPREDUCE-2322:
----------------------------------------

Hey Albert. Nice patch. A few small comments:

- JobHistoryPathFilter should have InterfaceAudience and InterfaceStability annotations. I'd
probably say @InterfaceAudience.Private and @InterfaceStability.Evolving. This will indicate
better that it's only package-accessible so that the jsp can get to it.
- please add at least a brief javadoc on what the filter does.
- Similarly, the comments at the head of matchUser, matchJobId, and validJobHistory should
probably be converted to JavaDoc comments with /** ... */ (I see you've just moved this code,
but while we're at it, we might as well fix that)
- the javadoc for TestJobHistoryPathFilter seems to refer to some other test
- can you please use JUnit 4 for the new test cases? i.e import org.junit.Test and use @Test
annotations instead of extending TestCase

Thanks!

> Throw better error message when malformed filenames in history dir
> ------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2322
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2322
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Albert Sunwoo
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-2322.patch, MAPREDUCE-2322.patch, MAPREDUCE-2322.patch, MAPREDUCE-2322.patch,
MAPREDUCE-2322.patch
>
>
> I've occasionally seen an IndexOutOfBoundsException visiting jobhistory.jsp because some
file makes it into the history log directory. We should filter these out and throw a more
useful exception if a malformed one somehow makes it to the comparator

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message