Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Wed, 9 Mar 2011 22:50:59 +0000 (UTC)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: 
 <2118417727.9445.1299711059584.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <724848734.8962.1299701160588.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Updated: (MAPREDUCE-2372) TaskLogAppender mechanism
 shouldn't be set in log4j.properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-2372:
-----------------------------------

    Attachment: mapreduce-2372.txt

Here's a patch which allows the settings to come directly from system properties.

Unfortunately, TLA isn't covered by any test cases yet, so nothing to change there.

We will need a patch on Common to remove the settings from log4j.properties as well.

> TaskLogAppender mechanism shouldn't be set in log4j.properties
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-2372
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2372
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2372.txt
>
>
> The TaskLogAppender log4j appender relies on using log4j.properties to pass in some Java system properties into properties of the logger. This is problematic since we've often found that users have customized log4j.properties and don't upgrade it when they upgrade the version of Hadoop.
> Since this is really an internal mechanism of how the task runner passes task info to the TLA, we shouldn't rely on these settings in log4j.properties at all. Rather, we should just get the system properties directly from System.getProperty.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira