hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2302) Add static factory methods in GaloisField
Date Tue, 01 Mar 2011 21:42:36 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001130#comment-13001130
] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-2302:
---------------------------------------------------

{code}
+    int key = ((fieldSize << 16) & 0xFF00) + (primitivePolynomial & 0xFF);
{code}
Since the shift is 16, should the masks be 0xFFFF0000 and 0xFFFF?

> Add static factory methods in GaloisField
> -----------------------------------------
>
>                 Key: MAPREDUCE-2302
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2302
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/raid
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: MAPREDUCE-2302.2.txt, MAPREDUCE-2302.txt
>
>
> GaloisField is immutable and should be kept reuse after creation to avoid redundant calculation
of the multiplication and division tables.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message