hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-1125) SerialUtils.cc: deserializeFloat is out of sync with SerialUtils.hh
Date Thu, 10 Mar 2011 18:21:59 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005222#comment-13005222
] 

Todd Lipcon commented on MAPREDUCE-1125:
----------------------------------------

This is a sort of incompatible change - some user might be explicitly declaring the extern
void deserializeFloat(float &t, InStream &stream), right?

Do we need to leave the old version around for a version? Perhaps someone who makes use of
SerialUtils can comment - I never have worked on significant amounts of C++ code with Hadoop

> SerialUtils.cc: deserializeFloat is out of sync with SerialUtils.hh
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1125
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1125
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: pipes
>    Affects Versions: 0.21.0
>            Reporter: Simone Leo
>            Assignee: Simone Leo
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-1125-2.patch
>
>
> {noformat}
> *** SerialUtils.hh ***
>   float deserializeFloat(InStream& stream);
> *** SerialUtils.cc ***
>   void deserializeFloat(float& t, InStream& stream)
>   {
>     char buf[sizeof(float)];
>     stream.read(buf, sizeof(float));
>     XDR xdrs;
>     xdrmem_create(&xdrs, buf, sizeof(float), XDR_DECODE);
>     xdr_float(&xdrs, &t);
>   }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message