hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAPREDUCE-2225) MultipleOutputs should not require the use of 'Writable'
Date Tue, 01 Mar 2011 11:02:36 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000822#comment-13000822
] 

Hadoop QA commented on MAPREDUCE-2225:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472201/multipleoutputs.nowritables.r2.diff
  against trunk revision 1075569.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/103//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/103//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/103//console

This message is automatically generated.

> MultipleOutputs should not require the use of 'Writable'
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-2225
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2225
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: job submission
>    Affects Versions: 0.20.1
>         Environment: Linux
>            Reporter: Harsh J Chouraria
>            Assignee: Harsh J Chouraria
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: multipleoutputs.nowritables.r1.diff, multipleoutputs.nowritables.r2.diff,
multipleoutputs.nowritables.r2.diff
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> MultipleOutputs right now requires for Key/Value classes to utilize the Writable and
WritableComparable interfaces, and fails if the associated key/value classes aren't doing
so.
> With support for alternates like Avro serialization, using Writables isn't necessary
and thus the MO class must not strictly check for them.
> And since comparators may be given separately, key class doesn't need to be checked for
implementing a comparable (although it is good design if the key class does implement Comparable
at least).
> Am not sure if this brings about an incompatible change (does Java have BIC? No idea).

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message