Return-Path: Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: (qmail 31420 invoked from network); 26 Feb 2011 15:32:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Feb 2011 15:32:30 -0000 Received: (qmail 41497 invoked by uid 500); 26 Feb 2011 15:32:30 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 41361 invoked by uid 500); 26 Feb 2011 15:32:28 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 41344 invoked by uid 99); 26 Feb 2011 15:32:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Feb 2011 15:32:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Feb 2011 15:32:26 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 4B7AF1B7487 for ; Sat, 26 Feb 2011 15:32:05 +0000 (UTC) Date: Sat, 26 Feb 2011 15:32:05 +0000 (UTC) From: "Hadoop QA (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <2126353713.159.1298734325305.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <17037086.210631292830021613.JavaMail.jira@thor> Subject: [jira] Commented: (MAPREDUCE-2226) TaggedInputSplit should be public MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAPREDUCE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999798#comment-12999798 ] Hadoop QA commented on MAPREDUCE-2226: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466646/MAPREDUCE-2226.diff against trunk revision 1074251. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/43//console This message is automatically generated. > TaggedInputSplit should be public > --------------------------------- > > Key: MAPREDUCE-2226 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2226 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Affects Versions: 0.20.1 > Reporter: E. Sammer > Assignee: E. Sammer > Attachments: MAPREDUCE-2226.diff > > > Currently it's not possible to get at the original InputSplits when using MultipleInputs. This is because TaggedInputSplit (used by DelegatingInputFormat used by MultipleInputs) is not public. This means things like the following do not work: > {code} > public void map(...) { > FileSplit fis = (FileSplit)((TaggedInputSplit) reporter.getInputSplit()).getInputSplit(); > Path p = fis.getPath(); > } > {code} > This prevents users from getting at input split specific data. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira